Skip to content

test for the bundled ns template tiers being annotated as such #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

test for the bundled ns template tiers being annotated as such #1154

wants to merge 10 commits into from
+35 −6

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jun 4, 2025

This tests the new functionality of automagically annotating the bundled NSTemplateTiers as such and makes sure that all the expected NSTemplateTiers have the expected annotation.

Related PRs:

@openshift-ci openshift-ci bot added the approved label Jun 4, 2025
This was referenced Jun 4, 2025
Open
Merged
@metlos metlos force-pushed the remove-unused-bundled-tiers branch from 35b93cd to 3d3b948 Compare June 5, 2025 14:46
rsoaresd
rsoaresd reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@rsoaresd rsoaresd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

rajivnathan
rajivnathan reviewed Jun 9, 2025
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: metlos

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved label Jun 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2025

@metlos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 6e92d58 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajivnathan rajivnathan rajivnathan left review comments

@rsoaresd rsoaresd rsoaresd left review comments

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek

@xcoulon xcoulon Awaiting requested review from xcoulon

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov

@mfrancisc mfrancisc Awaiting requested review from mfrancisc

@fbm3307 fbm3307 Awaiting requested review from fbm3307

@jrosental jrosental Awaiting requested review from jrosental

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metlos @rajivnathan @rsoaresd @alexeykazakov